From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsfX0-0001Nr-19
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:26:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsfWv-0001JA-DB
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:26:25 -0400
Received: from [199.232.76.173] (port=38084 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsfWv-0001Ix-8H
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:26:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7326)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MsfWu-0002kw-DH
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:26:20 -0400
Message-ID: <4AC23526.7080803@redhat.com>
Date: Tue, 29 Sep 2009 18:26:14 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix
References: <4ABF52A5.5080409@redhat.com> <20090927120041.GB24031@redhat.com>
	<4ABF585D.7000201@redhat.com> <20090927140841.GA24769@redhat.com>
	<4ABF7359.8050404@redhat.com> <20090927142129.GA24851@redhat.com>
	<20090927142422.GB24851@redhat.com>
	<f43fc5580909270819k61d552cgbd19da6c10918c11@mail.gmail.com>
	<20090929145006.GA3301@redhat.com>
	<f43fc5580909290815j1521ca30s8bfee81e2d123bcc@mail.gmail.com>
	<20090929155756.GA13666@redhat.com>
In-Reply-To: <20090929155756.GA13666@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 09/29/2009 05:57 PM, Michael S. Tsirkin wrote:
>
>> There is no such requirement anymore (since r2868 in 2007), devices
>> can register regions of arbitrary size and multiple devices can share
>> a page.
>>      
> Why does the comment on top of cpu_register_physical_memory_offset say
> otherwise then? Also, this function seems to call kvm_set_phys_mem,
> which also, apparently, assumes target page alignment.
>    

That's only for RAM, which the msix area isn't.

-- 
error compiling committee.c: too many arguments to function