From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsgSz-0001hn-Qh
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:26:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsgSv-0001dV-PB
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:26:21 -0400
Received: from [199.232.76.173] (port=59361 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsgSv-0001dN-M1
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:26:17 -0400
Received: from qw-out-1920.google.com ([74.125.92.144]:56115)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MsgSv-0008Ff-A8
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 13:26:17 -0400
Received: by qw-out-1920.google.com with SMTP id 5so1740739qwc.4
	for <qemu-devel@nongnu.org>; Tue, 29 Sep 2009 10:26:16 -0700 (PDT)
Message-ID: <4AC24335.80505@codemonkey.ws>
Date: Tue, 29 Sep 2009 12:26:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4AB8E88C.4040103@redhat.com> <4AB980E6.2070203@codemonkey.ws>
	<4AB9AA8E.7060800@third-harmonic.com> <4AC1A49A.1010308@redhat.com>
	<20090929065856.GC25389@redhat.com> <4AC1B5CD.7050702@redhat.com>
	<20090929085450.GE25389@redhat.com>
	<4AC211C8.1060202@codemonkey.ws>
	<20090929140601.GA28733@redhat.com>
	<4AC21660.6020304@codemonkey.ws>
	<20090929163039.GA14044@redhat.com>
In-Reply-To: <20090929163039.GA14044@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: john cooper <john.cooper@third-harmonic.com>, john cooper <john.cooper@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

Michael S. Tsirkin wrote:
> On Tue, Sep 29, 2009 at 09:14:56AM -0500, Anthony Liguori wrote:
>   
>> Michael S. Tsirkin wrote:
>>     
>>> I don't think it's such a good idea.  We want to keep exposing most of
>>> config space in i/o bar because of backwards compatibility.  And we want
>>> to keep datapath operations such as vq kicks, in i/o space.
>>>   
>>>       
>> We can do feature negotiation in virtio-pci.  That lets us continue  
>> exposing the first 246 bytes of the config space in PIO and guests can  
>> negotiate a second bar for access to larger config spaces.
>>
>> Regards,
>>
>> Anthony Liguori
>>     
>
> guests can't negotiate a bar.
>   

The host always exposes the config in two places.  config[0..235] in 
bytes 20-255 in BAR0 and the full config space in BAR2 (or BAR1 + offset 
if desired).  Old drivers will just ignore the new config location.

> What I think we want to do
> - Use i/o for small fields (2-4 bytes) as we did previously
>   we won't run out anytime soon
> - For large fields, put them in memory BAR1 and report the
>   offset in i/o space
>   

This is at best a band aid as a large number of small fields can result 
in the same problem.

> - For huge fields, provide a mailbox in i/o space where guest
>   writes an offset and reads out a value
>   

Regards,

Anthony Liguori