From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Msh8E-0007x0-5l
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:08:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Msh89-0007um-He
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:08:57 -0400
Received: from [199.232.76.173] (port=43138 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Msh89-0007ug-CF
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:08:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59000)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Msh88-0000JG-Ji
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:08:52 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8TI8pwf025805
	for <qemu-devel@nongnu.org>; Tue, 29 Sep 2009 14:08:51 -0400
Message-ID: <4AC24D31.2070709@redhat.com>
Date: Tue, 29 Sep 2009 20:08:49 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/6] virtio-console-port: Add a new device
	on	the virtio-console-bus for generic host-guest communication
References: <1254225888-17093-1-git-send-email-amit.shah@redhat.com>	<1254225888-17093-2-git-send-email-amit.shah@redhat.com>	<1254225888-17093-3-git-send-email-amit.shah@redhat.com>	<1254225888-17093-4-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-5-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1254225888-17093-5-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

> +typedef struct VirtIOConsole
> +{
> +    VirtConPort port;

Your CharDriverState should go here.

> +        DEFINE_PROP_INT32("flush_buffers", VirtConPort, flush_buffers, 0),

Well, we should find a better name for that one.  flush_buffers is very 
unclear.  It actually is dont_cache_data_when_unconnected.  That name is 
insane long though.

cheers,
   Gerd