From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MshDC-0003VU-0c
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:14:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MshD7-0003P1-IV
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:14:05 -0400
Received: from [199.232.76.173] (port=55084 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MshD7-0003Ok-6a
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:14:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34578)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MshD6-0001ik-Gd
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:14:00 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8TIDxXx002088
	for <qemu-devel@nongnu.org>; Tue, 29 Sep 2009 14:13:59 -0400
Message-ID: <4AC24E64.2020907@redhat.com>
Date: Tue, 29 Sep 2009 20:13:56 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/6] vnc: Add a virtio-console-bus device
	to	send / receive guest clipboard
References: <1254225888-17093-1-git-send-email-amit.shah@redhat.com>	<1254225888-17093-2-git-send-email-amit.shah@redhat.com>	<1254225888-17093-3-git-send-email-amit.shah@redhat.com>	<1254225888-17093-4-git-send-email-amit.shah@redhat.com>	<1254225888-17093-5-git-send-email-amit.shah@redhat.com>	<1254225888-17093-6-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-7-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1254225888-17093-7-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

>   static void client_cut_text(VncState *vs, size_t len, uint8_t *text)
>   {
> +    virtio_console_write(&virtcon_vnc->port, text, len);

Needs "if (virtcon_vnc)" ?

> +    if (virtcon_vnc) {
> +        virtio_console_open(&virtcon_vnc->port);
> +    }

Like it is done here?

There is no virtio_console_close() in this patch.  Does this work 
correctly after multiple connects + disconnects (with multiple vnc 
clients connected at the same time)?

I think when moving the buffering and host_connected state tracking into 
the port driver (patch 4/6) which is the only user of the facility you 
don't need these open/close calls at all.

cheers
   Gerd