From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MshFO-0004te-I4 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:16:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MshFJ-0004pN-FH for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:16:21 -0400 Received: from [199.232.76.173] (port=55176 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MshFJ-0004p9-6c for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:16:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56451) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MshFI-0002DH-L9 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 14:16:16 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8TIGFn3003317 for ; Tue, 29 Sep 2009 14:16:15 -0400 Message-ID: <4AC24EED.9030406@redhat.com> Date: Tue, 29 Sep 2009 20:16:13 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 12/13] pci: move unregister from PCIDevice to PCIDeviceInfo References: <1253611767-6483-1-git-send-email-kraxel@redhat.com> <1253611767-6483-13-git-send-email-kraxel@redhat.com> <20090923155844.GB18203@redhat.com> <4ABC75FC.6030408@redhat.com> <20090929155046.GA13634@redhat.com> In-Reply-To: <20090929155046.GA13634@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org Hi, > Yes, it works, but I find it confusing: IMO init and uninit being in > separate modules just makes code impossible to figure out. Ok, I'll change it for the next respin. cheers Gerd