From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Msokh-0005IT-0E
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 22:17:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Msokc-0005GR-JU
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 22:17:10 -0400
Received: from [199.232.76.173] (port=49852 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Msokc-0005G7-BU
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 22:17:06 -0400
Received: from qw-out-1920.google.com ([74.125.92.146]:44791)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Msokc-0002Vp-24
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 22:17:06 -0400
Received: by qw-out-1920.google.com with SMTP id 5so1901829qwc.4
	for <qemu-devel@nongnu.org>; Tue, 29 Sep 2009 19:17:03 -0700 (PDT)
Message-ID: <4AC2BF9C.9050403@codemonkey.ws>
Date: Tue, 29 Sep 2009 21:17:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4AB7A01A.3000206@redhat.com> <4AC25599.1090400@third-harmonic.com>
	<4AC2744B.1080601@codemonkey.ws>
	<200909301049.08434.rusty@rustcorp.com.au>
In-Reply-To: <200909301049.08434.rusty@rustcorp.com.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: john cooper <john.cooper@third-harmonic.com>, "Michael S. Tsirkin" <mst@redhat.com>, john cooper <john.cooper@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

Rusty Russell wrote:
> On Wed, 30 Sep 2009 06:25:39 am Anthony Liguori wrote:
>   
>> virtio-blk isn't an ATA device so why pretend like it is?
>>     
>
> Do you want to maintain a "vdparm" to match hdparm and sdparm?
>   

That's an argument to implement the HDIO_GET_IDENTITY ioctl in the Linux 
virtio-blk driver.  That's a totally reasonable thing to do.

However, baking something into the virtio-blk ABI because Linux requires 
an hdparm, sdparm, and potentially a vdparm doesn't seem like a good 
idea to me.  We should expose the information that makes sense for a 
virtio block device and if a guest wants to create an ATA identify 
response out of that data, more power to it.

Regards,

Anthony Liguori

> Confused,
> Rusty.
>