From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Msxo3-0004SF-Us
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:57:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Msxnz-0004OF-2s
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:57:15 -0400
Received: from [199.232.76.173] (port=49640 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Msxny-0004O0-MY
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:57:10 -0400
Received: from qw-out-1920.google.com ([74.125.92.145]:50852)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Msxny-0002Rn-5k
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 07:57:10 -0400
Received: by qw-out-1920.google.com with SMTP id 5so2005520qwc.4
	for <qemu-devel@nongnu.org>; Wed, 30 Sep 2009 04:57:09 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4AC34790.3080008@gnu.org>
Date: Wed, 30 Sep 2009 13:57:04 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <1253907783-1231-1-git-send-email-kraxel@redhat.com>
	<1253907783-1231-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1253907783-1231-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RfC PATCH 1/3] net: macaddr tweaks.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org


> +void qemu_macaddr_default_if_unset(macaddr_t macaddr)
> +{
> +    macaddr_t zero = { 0,0,0,0,0,0 };

Very minor since this is not at all a hot path, but please make it just

   static macaddr_t zero;

since otherwise it would be initialized on the stack at run time.

Paolo