From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark McLoughlin <markmc@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream
Date: Wed, 30 Sep 2009 15:55:33 +0200 [thread overview]
Message-ID: <4AC36355.8040908@redhat.com> (raw)
In-Reply-To: <20090930135144.GA29956@infradead.org>
On 09/30/2009 03:51 PM, Christoph Hellwig wrote:
> I might sound like a broken record, but why isn't the full GSO support
> for virtio-net upstream in qemu?
>
IIRC the current hacks are not upstream quality.
The problem (again IIRC) is that the guest and host negotiate a
protocol, but the qemu vlan model doesn't have a guest and a host, it
has peers (possibly more than two), so a lot of translation has to take
place if you have one peer supporting a guest feature and another not.
IMO the best way out is to drop the vlan model. It has its uses, but
they can all be implemented in other ways, and are all have minor usage
compared to the business of getting data into and out of a guest.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-30 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1241459088.26045.1.camel@lappy>
[not found] ` <1241513785-28738-1-git-send-email-markmc@redhat.com>
[not found] ` <1254257151.29022.11.camel@blaa>
2009-09-30 13:51 ` [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream Christoph Hellwig
2009-09-30 13:55 ` Avi Kivity [this message]
2009-09-30 13:59 ` Mark McLoughlin
2009-09-30 19:15 ` Gerd Hoffmann
2009-10-01 6:59 ` Mark McLoughlin
2009-10-01 16:49 ` Avi Kivity
2009-10-01 17:00 ` Mark McLoughlin
2009-10-01 17:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC36355.8040908@redhat.com \
--to=avi@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).