From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mszen-0000oT-5K for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:55:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mszei-0000lV-Dk for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:55:48 -0400 Received: from [199.232.76.173] (port=46302 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mszei-0000lP-8i for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:55:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32156) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mszeg-0006Wu-4n for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:55:42 -0400 Message-ID: <4AC36355.8040908@redhat.com> Date: Wed, 30 Sep 2009 15:55:33 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1241459088.26045.1.camel@lappy> <1241513785-28738-1-git-send-email-markmc@redhat.com> <1254257151.29022.11.camel@blaa> <20090930135144.GA29956@infradead.org> In-Reply-To: <20090930135144.GA29956@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Mark McLoughlin , qemu-devel@nongnu.org, kvm@vger.kernel.org On 09/30/2009 03:51 PM, Christoph Hellwig wrote: > I might sound like a broken record, but why isn't the full GSO support > for virtio-net upstream in qemu? > IIRC the current hacks are not upstream quality. The problem (again IIRC) is that the guest and host negotiate a protocol, but the qemu vlan model doesn't have a guest and a host, it has peers (possibly more than two), so a lot of translation has to take place if you have one peer supporting a guest feature and another not. IMO the best way out is to drop the vlan model. It has its uses, but they can all be implemented in other ways, and are all have minor usage compared to the business of getting data into and out of a guest. -- error compiling committee.c: too many arguments to function