From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt32B-0003EW-QF for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:32:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt327-00038e-Ru for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:32:11 -0400 Received: from [199.232.76.173] (port=40854 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt327-00038K-HZ for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:32:07 -0400 Received: from lo.gmane.org ([80.91.229.12]:40859) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mt327-0002UY-6A for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:32:07 -0400 Received: from list by lo.gmane.org with local (Exim 4.50) id 1Mt323-0002h3-L4 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:32:03 +0200 Received: from nat-pool-brq.redhat.com ([62.40.79.66]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 30 Sep 2009 19:32:03 +0200 Received: from bonzini by nat-pool-brq.redhat.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 30 Sep 2009 19:32:03 +0200 From: Paolo Bonzini Date: Wed, 30 Sep 2009 19:31:36 +0200 Message-ID: <4AC395F8.8030004@gnu.org> References: <20090923200635.GA21246@redhat.com> <20090924191121.GB29419@redhat.com> <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <20090930135142.GA20378@redhat.com> Sender: news Subject: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl >> We could also select a new style, like Linux kernel one. I'm also not >> a great fan of that either. But at least 'indent' could be used very >> easily and I think there would be other benefits, like reuse of Git >> hooks, patch checking scripts and Emacs configs. With full 'indent' >> support all sources could be massaged mechanically to make the switch >> less painful. >> >> Then there are K&R and GNU styles, but I like them even less. > > So ... Linux kernel style wins? What do others think? Linux kernel with 4-char indent? That would avoid the need to run indent (indent requires knowledge of all the names of the types, so a mechanical pass through the sources is more easily said than done). Paolo