From: Gerd Hoffmann <kraxel@redhat.com>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Reorganize option rom (+linux kernel) loading.
Date: Wed, 30 Sep 2009 21:07:17 +0200 [thread overview]
Message-ID: <4AC3AC65.7090809@redhat.com> (raw)
In-Reply-To: <m34oqkmf0n.fsf@neno.mitica>
On 09/30/09 21:03, Juan Quintela wrote:
> Gerd Hoffmann<kraxel@redhat.com> wrote:
>
>> +
>> +static void rom_insert(const char *type, Rom *rom)
>
> You are not using the type parameter,
Indeed. There was a debug message which used the type parameter. Guess
it can be zapped now.
> I guess that a field inside struct
> Rom could make sense.
I don't think so. What for?
cheers,
Gerd
next prev parent reply other threads:[~2009-09-30 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 15:43 [Qemu-devel] [PATCH] Reorganize option rom (+linux kernel) loading Gerd Hoffmann
[not found] ` <m34oqkmf0n.fsf@neno.mitica>
2009-09-30 19:07 ` Gerd Hoffmann [this message]
2009-09-30 19:51 ` Blue Swirl
2009-10-01 9:11 ` Gerd Hoffmann
2009-10-01 16:25 ` Blue Swirl
2009-10-02 11:40 ` Gerd Hoffmann
2009-10-02 15:19 ` Gerd Hoffmann
2009-10-02 17:58 ` Blue Swirl
2009-10-06 21:18 ` Gerd Hoffmann
2009-10-02 17:56 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC3AC65.7090809@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@trasno.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).