From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mt4WL-0001tS-Ew
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:07:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mt4WG-0001m1-Of
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:07:25 -0400
Received: from [199.232.76.173] (port=54335 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mt4WG-0001la-M2
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:07:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33105)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mt4WG-0005EU-0I
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:07:20 -0400
Message-ID: <4AC3AC65.7090809@redhat.com>
Date: Wed, 30 Sep 2009 21:07:17 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1254325401-18777-1-git-send-email-kraxel@redhat.com>
	<m34oqkmf0n.fsf@neno.mitica>
In-Reply-To: <m34oqkmf0n.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Reorganize option rom (+linux kernel)
	loading.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org

On 09/30/09 21:03, Juan Quintela wrote:
> Gerd Hoffmann<kraxel@redhat.com>  wrote:
>
>> +
>> +static void rom_insert(const char *type, Rom *rom)
>
> You are not using the type parameter,

Indeed.  There was a debug message which used the type parameter.  Guess 
it can be zapped now.

> I guess that a field inside struct
> Rom could make sense.

I don't think so.  What for?

cheers,
   Gerd