From: Anthony Liguori <anthony@codemonkey.ws>
To: "John R. Lange" <jarusl@cs.northwestern.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap lookup for low order MSRs
Date: Wed, 30 Sep 2009 14:19:10 -0500 [thread overview]
Message-ID: <4AC3AF2E.20104@codemonkey.ws> (raw)
In-Reply-To: <Pine.LNX.4.64.0909171511210.24341@zappa.cs.northwestern.edu>
John R. Lange wrote:
>
> It looks like there was a minor calculation error in the SVM_EXIT_MSR
> bitmap lookup.
Missinged Signed-off-by, also doesn't apply to tip.
Regards,
Anthony Liguori
> ---
> target-i386/op_helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index c3f5af6..dcee7a3 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t
> type, uint64_t param)
> switch((uint32_t)ECX) {
> case 0 ... 0x1fff:
> t0 = (ECX * 2) % 8;
> - t1 = ECX / 8;
> + t1 = (ECX * 2) / 8;
> break;
> case 0xc0000000 ... 0xc0001fff:
> t0 = (8192 + ECX - 0xc0000000) * 2;
next prev parent reply other threads:[~2009-09-30 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 20:13 [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap lookup for low order MSRs John R. Lange
2009-09-30 19:19 ` Anthony Liguori [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-18 18:11 John R. Lange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC3AF2E.20104@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jarusl@cs.northwestern.edu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).