From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mt4hs-0003fz-PR
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:19:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mt4ho-0003aW-4I
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:19:20 -0400
Received: from [199.232.76.173] (port=47533 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mt4hn-0003aI-W2
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:19:16 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:61549)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mt4hn-0007lX-Me
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:19:15 -0400
Received: by fxm10 with SMTP id 10so2110114fxm.8
	for <qemu-devel@nongnu.org>; Wed, 30 Sep 2009 12:19:14 -0700 (PDT)
Message-ID: <4AC3AF2E.20104@codemonkey.ws>
Date: Wed, 30 Sep 2009 14:19:10 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap
	lookup for low order MSRs
References: <Pine.LNX.4.64.0909171511210.24341@zappa.cs.northwestern.edu>
In-Reply-To: <Pine.LNX.4.64.0909171511210.24341@zappa.cs.northwestern.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "John R. Lange" <jarusl@cs.northwestern.edu>
Cc: qemu-devel@nongnu.org

John R. Lange wrote:
>
> It looks like there was a minor calculation error in the SVM_EXIT_MSR 
> bitmap lookup.

Missinged Signed-off-by, also doesn't apply to tip.

Regards,

Anthony Liguori

> ---
>  target-i386/op_helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index c3f5af6..dcee7a3 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t 
> type, uint64_t param)
>              switch((uint32_t)ECX) {
>              case 0 ... 0x1fff:
>                  t0 = (ECX * 2) % 8;
> -                t1 = ECX / 8;
> +                t1 = (ECX * 2) / 8;
>                  break;
>              case 0xc0000000 ... 0xc0001fff:
>                  t0 = (8192 + ECX - 0xc0000000) * 2;