From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt53s-0002Zn-FV for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:42:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt53n-0002Sl-Ki for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:42:04 -0400 Received: from [199.232.76.173] (port=39328 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt53n-0002SV-Ev for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:41:59 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:47384) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mt53n-0003ER-1x for qemu-devel@nongnu.org; Wed, 30 Sep 2009 15:41:59 -0400 Received: by fg-out-1718.google.com with SMTP id d23so2114533fga.10 for ; Wed, 30 Sep 2009 12:41:58 -0700 (PDT) Message-ID: <4AC3B480.2050709@codemonkey.ws> Date: Wed, 30 Sep 2009 14:41:52 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 16/24] Port -net tap to QemuOpts References: <1253701463-3134-1-git-send-email-markmc@redhat.com> <1253701463-3134-17-git-send-email-markmc@redhat.com> In-Reply-To: <1253701463-3134-17-git-send-email-markmc@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: qemu-devel@nongnu.org Mark McLoughlin wrote: > -static void tap_set_sndbuf(TAPState *s, const char *sndbuf_str, Monitor *mon) > +static void tap_set_sndbuf(TAPState *s, QemuOpts *opts, Monitor *mon) > { > if (sndbuf_str) { > config_error(mon, "No '-net tap,sndbuf=' support available\n"); > @@ -2546,6 +2543,92 @@ static int net_init_slirp(QemuOpts *opts, Monitor *mon) > return ret; > } > Breaks the build. Regards, Anthony Liguori