From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt6Hm-00033l-2E for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:00:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt6Hh-00031n-D9 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:00:29 -0400 Received: from [199.232.76.173] (port=60922 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt6Hh-00031i-48 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:00:25 -0400 Received: from mail-fx0-f214.google.com ([209.85.220.214]:52975) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mt6Hg-00076i-F3 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:00:24 -0400 Received: by fxm10 with SMTP id 10so2194228fxm.8 for ; Wed, 30 Sep 2009 14:00:22 -0700 (PDT) Message-ID: <4AC3C6E1.1090105@codemonkey.ws> Date: Wed, 30 Sep 2009 16:00:17 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix) References: <20090923200635.GA21246@redhat.com> <20090924191121.GB29419@redhat.com> <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> <4AC395F8.8030004@gnu.org> In-Reply-To: <4AC395F8.8030004@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , qemu-devel@nongnu.org Paolo Bonzini wrote: > >>> We could also select a new style, like Linux kernel one. I'm also not >>> a great fan of that either. But at least 'indent' could be used very >>> easily and I think there would be other benefits, like reuse of Git >>> hooks, patch checking scripts and Emacs configs. With full 'indent' >>> support all sources could be massaged mechanically to make the switch >>> less painful. >>> >>> Then there are K&R and GNU styles, but I like them even less. >> >> So ... Linux kernel style wins? What do others think? > > Linux kernel with 4-char indent? That would avoid the need to run > indent (indent requires knowledge of all the names of the types, so a > mechanical pass through the sources is more easily said than done). I strongly disagree with running indent against the source tree. Indentation is purely cosmetic and honestly is something people get too upset about. Doing something like a flag day indent run would result in git annotate becoming more or less useless. I prefer having tools that we can use to debug real code instead of worry about indentation. Regards, Anthony Liguori