From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mt6SD-0002fF-RN
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:11:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mt6S9-0002Wr-5l
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:11:17 -0400
Received: from [199.232.76.173] (port=43966 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mt6S8-0002Wa-Qz
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:11:12 -0400
Received: from mail-bw0-f211.google.com ([209.85.218.211]:37977)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mt6S8-0000Od-FT
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 17:11:12 -0400
Received: by bwz7 with SMTP id 7so856003bwz.34
	for <qemu-devel@nongnu.org>; Wed, 30 Sep 2009 14:11:11 -0700 (PDT)
Message-ID: <4AC3C96A.9020103@codemonkey.ws>
Date: Wed, 30 Sep 2009 16:11:06 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state
References: <cover.1254255997.git.quintela@redhat.com>
	<d93032e20d443aeb567c2dcee9c6d4d166b98d58.1254255997.git.quintela@redhat.com>
	<Pine.LNX.4.64.0909301435150.2147@linmac.oyster.ru>
	<m3zl8cwtmp.fsf@neno.mitica>
	<Pine.LNX.4.64.0909301545110.3147@linmac.oyster.ru>
	<4AC37476.60007@codemonkey.ws>
	<Pine.LNX.4.64.0909301922360.14276@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0909301922360.14276@linmac.oyster.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

malc wrote:
> On Wed, 30 Sep 2009, Anthony Liguori wrote:
>   
>> So I think we should bump the version of the ac97 format, remove the 
>> active[] array from the vmstate, and then generate it in a post function 
>> that can then be passed to reset_voices().
>>     
>
> Yes, however, what bothers me though, is that i ended up NOT doing that
> when the original code was written, there must have been a reason for me
> not doing that, and it completely elludes me at the moment, so no this
> isn't better yet, better yet implies someone having to go through the
> code and figure out whether it's safe or not.
>   

I'm pretty convinced it's safe.  The only way it wouldn't be is if it 
was possible for the active_in/active_out state in AUD to be changed 
through a means other than the device itself.  Looking at audio.c, it's 
not possible.

But I also expect that Juan will be testing this device model when he 
resubmits the patch so that should confirm it.

Regards,

Anthony Liguori