From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt8XK-0004ve-Dd for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:24:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt8XF-0004vR-Va for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:24:41 -0400 Received: from [199.232.76.173] (port=54458 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt8XF-0004vO-QI for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:24:37 -0400 Received: from fg-out-1718.google.com ([72.14.220.158]:1411) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mt8XF-00006v-8m for qemu-devel@nongnu.org; Wed, 30 Sep 2009 19:24:37 -0400 Received: by fg-out-1718.google.com with SMTP id e21so1486566fga.10 for ; Wed, 30 Sep 2009 16:24:36 -0700 (PDT) Message-ID: <4AC3E8AF.6070600@codemonkey.ws> Date: Wed, 30 Sep 2009 18:24:31 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: CODING_STYLE References: <20090923200635.GA21246@redhat.com> <20090924191121.GB29419@redhat.com> <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> <4AC395F8.8030004@gnu.org> <4AC3C6E1.1090105@codemonkey.ws> <87ws3g82ba.fsf@pike.pond.sub.org> In-Reply-To: <87ws3g82ba.fsf@pike.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Blue Swirl , Paolo Bonzini , qemu-devel@nongnu.org Markus Armbruster wrote: > Anthony Liguori writes: > > >> I strongly disagree with running indent against the source tree. >> Indentation is purely cosmetic and honestly is something people get >> too upset about. Doing something like a flag day indent run would >> result in git annotate becoming more or less useless. >> > > FWIW, git-blame -w exists. > That's pretty useful. It's still a merge nightmare though. Anyone carrying patches or downstream is going to have a massive headache due to conflicts. Regards, Anthony Liguori > [...] >