From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtHhB-00029A-RM
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:11:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtHh6-00021f-Hh
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:11:28 -0400
Received: from [199.232.76.173] (port=56923 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtHh6-00021N-BP
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:11:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43089)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MtHh5-0001BN-Us
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:11:24 -0400
Message-ID: <4AC471F4.4030308@redhat.com>
Date: Thu, 01 Oct 2009 11:10:12 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target
	library, use it in msix)
References: <20090924191121.GB29419@redhat.com>
	<f43fc5580909241313s64f14688he6cdb23e2bc2edfb@mail.gmail.com>
	<20090929161115.GA13885@redhat.com>
	<f43fc5580909291115y4ac36d4bja3a9bb5937312e44@mail.gmail.com>
	<20090930135142.GA20378@redhat.com> <4AC38EA4.70700@redhat.com>
	<f43fc5580909301029u1b777f9fhb114cf3e313f671b@mail.gmail.com>
	<4AC3C70C.4020002@codemonkey.ws> <20091001061721.GC5142@redhat.com>
	<4AC46BA4.1090503@redhat.com> <20091001085848.GC5718@redhat.com>
In-Reply-To: <20091001085848.GC5718@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

Am 01.10.2009 10:58, schrieb Michael S. Tsirkin:
> On Thu, Oct 01, 2009 at 10:43:16AM +0200, Kevin Wolf wrote:
>> Am 01.10.2009 08:17, schrieb Michael S. Tsirkin:
>>> On Wed, Sep 30, 2009 at 04:01:00PM -0500, Anthony Liguori wrote:
>>>> Blue Swirl wrote:
>>>>> On Wed, Sep 30, 2009 at 8:00 PM, Avi Kivity <avi@redhat.com> wrote:
>>>>>   
>>>>>> On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote:
>>>>>>     
>>>>>>> So ... Linux kernel style wins? What do others think?
>>>>>>>
>>>>>>>       
>>>>>> Any change is going to cause a large amount of pain if implemented.
>>>>>>     
>>>>>
>>>>> True, but with 'indent' support the pain would be brief.
>>>>>   
>>>>
>>>> It's equivalent to losing a massive amount of revision history which  
>>>> hurts debugging.
>>>
>>> It is? Why is it? git bisect still works. what else do you use
>>> for debugging that gets broken?
>>
>> git blame.
>>
>> Kevin
> 
> I think git blame has "-w" flag to ignore whitespace changes.

Are we only talking about changing the indentation?  Switching from 4
spaces to tabs of 8 characters also means additional line breaks and so
on (or does it handle these, too?). And I thought I read in this thread
about braces, typedefs and probably some more things. Can -w really
handle all of them?

Kevin