From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtO60-0001kR-W0
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:01:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtO5w-0001hv-9D
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:01:32 -0400
Received: from [199.232.76.173] (port=34068 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtO5w-0001hk-20
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:01:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31411)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MtO5v-00050W-Ic
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:01:27 -0400
Message-ID: <4AC4D250.3060903@redhat.com>
Date: Thu, 01 Oct 2009 18:01:20 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1254412245-10452-1-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1254412245-10452-1-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v1 00/14]: Initial QObject conversion
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 10/01/2009 05:50 PM, Luiz Capitulino wrote:
>   Hi there,
>
>   This series is an updated version of my initial QObject conversion series,
> which adds the needed infrastructure to incrementally support new style
> QObject handlers without breaking the current ones.
>
>   Some people have suggested that we should have a better error handling
> in the Monitor, in the meaning that error information should be correctly
> propagated and handled in order to be used by the Monitor Protocol and
> the existing user protocol.
>
>   This series introduces the MonitorError data type to solve that problem,
> it's used as part of the new infrastructure.
>
>   Additionally the following handlers are converted: do_quit(), do_stop(),
> do_system_reset(), do_system_powerdown(), do_balloon(), do_info_version(),
> do_info_balloon().
>
>   I've done a full build of QEMU with this series applied on Fedora 11 x86_64
> and Debian Lenny i386, also tested manually all converted commands plus some
> easy ones.
>
>   Please, review this carefully as some design decisions made here will
> have impact in the Monitor Protocol.
>
>    

Looks good to me.

Regarding info, I think the machine protocol should manage it as 
separate commands ("info-cpus" instead of "info"("cpus")).  Having a 
function which returns wildly different return types (a string for 
version, a device tree for qdev) is unwieldy.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.