From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtOqu-0004Kw-98 for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:50:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtOqp-0004F0-3b for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:49:59 -0400 Received: from [199.232.76.173] (port=55736 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtOqo-0004Eq-R9 for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:49:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16949) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtOqo-0001Nd-1K for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:49:54 -0400 Message-ID: <4AC4DDA7.9070708@redhat.com> Date: Thu, 01 Oct 2009 18:49:43 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1241459088.26045.1.camel@lappy> <1241513785-28738-1-git-send-email-markmc@redhat.com> <1254257151.29022.11.camel@blaa> <20090930135144.GA29956@infradead.org> <4AC36355.8040908@redhat.com> <1254319160.3105.67.camel@blaa> In-Reply-To: <1254319160.3105.67.camel@blaa> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Christoph Hellwig , qemu-devel@nongnu.org, kvm@vger.kernel.org On 09/30/2009 03:59 PM, Mark McLoughlin wrote: > I think we should keep the vlan stuff, just de-emphasise it. > Maybe we should do what X.org does, break it silently and remove it some time later when no one complains. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.