From: Avi Kivity <avi@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v1 00/14]: Initial QObject conversion
Date: Sat, 03 Oct 2009 09:59:39 +0200 [thread overview]
Message-ID: <4AC7046B.2000505@redhat.com> (raw)
In-Reply-To: <20091001182108.51a96a17@doriath>
On 10/01/2009 11:21 PM, Luiz Capitulino wrote:
>> Regarding info, I think the machine protocol should manage it as
>> separate commands ("info-cpus" instead of "info"("cpus")). Having a
>> function which returns wildly different return types (a string for
>> version, a device tree for qdev) is unwieldy.
>>
> I agree and I think this approach would make my life easier.
>
I was thinking more of client writers.
> The problem though is how to properly refactor the code so that
> we don't conflict with the user's 'info cpus' command.
>
> I will think about it, but would be good to decide this before
> mass conversion.
>
One approach would be to have two command tables, one for ordinary
commands and one for info commands. The machine monitor can scan the
two tables sequentially, while the human monitor will only scan the
first table, and the second as a response to an 'info' command.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-10-03 7:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 15:50 [Qemu-devel] [PATCH v1 00/14]: Initial QObject conversion Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 01/14] QObject: Accept NULL Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 02/14] Introduce monitor-error module Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 03/14] monitor: Add new members to mon_cmd_t Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 04/14] monitor: Handle new and old style handlers Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 05/14] monitor: Initial MonitorError usage Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 06/14] monitor: do_info(): handle new and old info handlers Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 07/14] monitor: Convert do_quit() do QObject Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 08/14] monitor: Convert do_stop() to QObject Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 09/14] monitor: Convert do_system_reset() " Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 10/14] monitor: Convert do_system_powerdown() " Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 11/14] monitor: Convert do_balloon() " Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 12/14] monitor: Convert do_info_version() " Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 13/14] monitor-error: Add do_info_balloon() errors Luiz Capitulino
2009-10-01 15:50 ` [Qemu-devel] [PATCH 14/14] monitor: Convert do_info_balloon() to QObject Luiz Capitulino
2009-10-01 16:01 ` [Qemu-devel] Re: [PATCH v1 00/14]: Initial QObject conversion Avi Kivity
2009-10-01 21:21 ` Luiz Capitulino
2009-10-03 7:59 ` Avi Kivity [this message]
2009-10-05 13:16 ` Luiz Capitulino
2009-10-02 12:47 ` [Qemu-devel] " Gerd Hoffmann
2009-10-02 13:47 ` Luiz Capitulino
2009-10-02 14:17 ` Gerd Hoffmann
2009-10-02 14:55 ` Luiz Capitulino
2009-10-02 15:36 ` Gerd Hoffmann
2009-10-02 18:32 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC7046B.2000505@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).