From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MunUT-0002gE-Lw for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:20:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MunUO-0002ek-5k for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:20:36 -0400 Received: from [199.232.76.173] (port=52081 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MunUO-0002eh-3W for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:20:32 -0400 Received: from mail-yw0-f179.google.com ([209.85.211.179]:48873) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MunUN-0003Uc-QY for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:20:31 -0400 Received: by ywh9 with SMTP id 9so3391651ywh.19 for ; Mon, 05 Oct 2009 06:20:31 -0700 (PDT) Message-ID: <4AC9F29B.5060404@codemonkey.ws> Date: Mon, 05 Oct 2009 08:20:27 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] eepro100: Remove unused device status entries References: <1253360475-10671-1-git-send-email-weil@mail.berlios.de> <4AB4FF9C.80005@mail.berlios.de> In-Reply-To: <4AB4FF9C.80005@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Juan Quintela , QEMU Developers Stefan Weil wrote: > Personally, I prefer version numbers which express something, for example > the date of a change (as in my case). If it helps, I promise to send a patch > which sets the version number to 4 as soon as the rest of eepro100.c is ok. > > Antony, please take the patch for now as it is, because I won't send a > new one > just to change the version number. > No, the version number is wrong. It also shouldn't be a variable. And since eepro100 was in the 0.11.0 release, we need support backwards compatibility appropriately. Regards, Anthony Liguori > Regards > > Stefan > > > >