From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MunXz-0003nK-V2
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:24:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MunXv-0003kr-Gm
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:24:15 -0400
Received: from [199.232.76.173] (port=52142 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MunXv-0003kk-7U
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:24:11 -0400
Received: from mail-yx0-f173.google.com ([209.85.210.173]:65527)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MunXu-0003zT-U7
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 09:24:11 -0400
Received: by yxe3 with SMTP id 3so2833931yxe.4
	for <qemu-devel@nongnu.org>; Mon, 05 Oct 2009 06:24:10 -0700 (PDT)
Message-ID: <4AC9F378.6070905@codemonkey.ws>
Date: Mon, 05 Oct 2009 08:24:08 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Implement the trivial diagnose CU and RU
	abort commands. These are necessary to make the device work with
	OpenSolaris 0609 (111b).
References: <20090912135045.GA15004@1und1.de>
In-Reply-To: <20090912135045.GA15004@1und1.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Reimar Döffinger wrote:
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
> ---
>  hw/eepro100.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 2099459..7c951c0 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -771,6 +771,10 @@ static void eepro100_cu_command(EEPRO100State * s, uint8_t val)
>              /* Starting with offset 8, the command contains
>               * 64 dwords microcode which we just ignore here. */
>              break;
> +        case CmdDiagnose:
> +            logout("diagnose\n");
> +            status = 0; // make sure error flag is not set
>   

Please avoid introducing C99 comments.  Also keep the first sentence of 
the description concise and < 80 characters.

Regards,

Anthony Liguori