From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MupoH-0006xy-L4 for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:49:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MupoA-0006vr-Db for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:49:12 -0400 Received: from [199.232.76.173] (port=43582 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mupo9-0006vg-Ql for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:49:05 -0400 Received: from dpc6682208002.direcpc.com ([66.82.208.2]:52376 helo=anvil.third-harmonic.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mupo8-0007yJ-2E for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:49:05 -0400 Message-ID: <4ACA136F.5070807@third-harmonic.com> Date: Mon, 05 Oct 2009 11:40:31 -0400 From: john cooper MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage References: <4AB7A01A.3000206@redhat.com> <4AC25599.1090400@third-harmonic.com> <4AC2744B.1080601@codemonkey.ws> <200909301247.46394.paul@codesourcery.com> In-Reply-To: <200909301247.46394.paul@codesourcery.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: "Michael S. Tsirkin" , john cooper , Rusty Russell , qemu-devel@nongnu.org, Avi Kivity , jens.axboe@oracle.com, Vadim Rozenfeld Paul Brook wrote: > Agreed. If we're going to copy anything than my vote would be for SCSI. We > already have partial support for feeding SCSI commands to a virtio device. > TBH I wouldn't have bothered with virtio-blk at all, and gone straight for > virtio-scsi. I guess it's a bit late for that though. Initially the patch introduced a dedicated ioctl in the guest driver to retrieve this data. Review comments from that version suggested using an existing interface which to me seemed reasonable. I had looked first at implementing the above via a scsi INQUIRY cmd. But at least at that time this option would have been more invasive to the existing code vs. just doing the equivalent via an ATA HDIO_GET_IDENTITY. -john -- john.cooper@third-harmonic.com