From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Muprs-0007wv-04
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:52:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Muprn-0007uM-FJ
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:52:55 -0400
Received: from [199.232.76.173] (port=53220 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Muprn-0007uD-44
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:52:51 -0400
Received: from dpc6682208002.direcpc.com ([66.82.208.2]:52487
	helo=anvil.third-harmonic.com) by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <john.cooper@third-harmonic.com>) id 1Muprl-00005N-4a
	for qemu-devel@nongnu.org; Mon, 05 Oct 2009 11:52:50 -0400
Message-ID: <4ACA147B.8050406@third-harmonic.com>
Date: Mon, 05 Oct 2009 11:44:59 -0400
From: john cooper <john.cooper@third-harmonic.com>
MIME-Version: 1.0
References: <4AB7A01A.3000206@redhat.com>
	<200909300258.17297.rusty@rustcorp.com.au>
	<4AC24460.1040305@codemonkey.ws>
	<200909301042.22358.rusty@rustcorp.com.au>
In-Reply-To: <200909301042.22358.rusty@rustcorp.com.au>
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, john cooper <john.cooper@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

Rusty Russell wrote:
> Calling the ATA IDENTIFY command a Linux ABI quirk is disingenuous.

I think ATA has earned that moniker all by itself.

> Not sure what the SCSI equiv is to get a serial number (VPD?) But if everyone
> is happy with 20 bytes, and John wants to do SN that way, I'll take the patch.

I've been swayed from one side to the other of
this argument.  Still I'd begrudgingly give my
vote to the ATA option only because it reuses an
existing wart vs. introducing a new one.

Updated qemu patch follows leveraging your virtqueue
REQ_TYPE_SPECIAL scaffolding.  At this point only
the issue of this guest visible interface should
remain.

-john


-- 
john.cooper@third-harmonic.com