From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Murw9-0004Ja-SK for qemu-devel@nongnu.org; Mon, 05 Oct 2009 14:05:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Murw5-0004Hw-92 for qemu-devel@nongnu.org; Mon, 05 Oct 2009 14:05:29 -0400 Received: from [199.232.76.173] (port=34330 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Murw4-0004Ho-Tx for qemu-devel@nongnu.org; Mon, 05 Oct 2009 14:05:24 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:63166) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Murw4-0007WF-Ac for qemu-devel@nongnu.org; Mon, 05 Oct 2009 14:05:24 -0400 Message-ID: <4ACA355C.1080802@mail.berlios.de> Date: Mon, 05 Oct 2009 20:05:16 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] eepro100: Add more i825xx devices References: <1253358129-10347-1-git-send-email-weil@mail.berlios.de> <4AC9F328.3020609@codemonkey.ws> In-Reply-To: <4AC9F328.3020609@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: QEMU Developers Anthony Liguori schrieb: > Stefan Weil wrote: >> The new devices added here are still not functional - >> partially because some patches are still missing, >> partially because I cannot test them. Nevertheless >> they belong to the same family and will be supported >> by this driver some day. >> >> As soon as they work, they will also be added to hw/pci.c. >> > > I don't like the idea of adding devices that are known to not work. > This is why PPC is such a mess. > > Regards, > > Anthony Liguori > Anthony, you asked me to send my maintainer version from git://repo.or.cz/qemu/ar7.git in small patches. Of course, the final goal is to have devices which work. To have a list of devices which should be supported helps other people who want to contribute to eepro100.c. They won't write code just for i82557c if the same code should be applied to i82557[ab] as well, for example. Regards Stefan