From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] qemu/pci: make pci not depend on msix
Date: Mon, 05 Oct 2009 23:21:26 +0200 [thread overview]
Message-ID: <4ACA6356.3060109@redhat.com> (raw)
In-Reply-To: <20091005210220.GA4490@redhat.com>
On 10/05/09 23:02, Michael S. Tsirkin wrote:
> Making pci device cleanup msix automatically makes pci.c depend on
> msix.c, which is IMO messy. Since devices do msix_init it's easy and
> natural for them to also do msix_uninit.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> Cc: Gerd Hoffmann<kraxel@redhat.com>
ACK.
Patch looks fine, and we've already agreed on doing it this way (devices
are responsible for both msix_init and msix_uninit).
I just didn't respin my patch series fast enougth ;)
cheers,
Gerd
prev parent reply other threads:[~2009-10-05 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 21:02 [Qemu-devel] [PATCH] qemu/pci: make pci not depend on msix Michael S. Tsirkin
2009-10-05 21:21 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACA6356.3060109@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).