From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Muuzv-0006pW-4M for qemu-devel@nongnu.org; Mon, 05 Oct 2009 17:21:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Muuzq-0006pB-DX for qemu-devel@nongnu.org; Mon, 05 Oct 2009 17:21:34 -0400 Received: from [199.232.76.173] (port=51600 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Muuzq-0006p8-7K for qemu-devel@nongnu.org; Mon, 05 Oct 2009 17:21:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61965) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Muuzp-0003so-RM for qemu-devel@nongnu.org; Mon, 05 Oct 2009 17:21:30 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n95LLSb4014240 for ; Mon, 5 Oct 2009 17:21:29 -0400 Message-ID: <4ACA6356.3060109@redhat.com> Date: Mon, 05 Oct 2009 23:21:26 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <20091005210220.GA4490@redhat.com> In-Reply-To: <20091005210220.GA4490@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qemu/pci: make pci not depend on msix List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 10/05/09 23:02, Michael S. Tsirkin wrote: > Making pci device cleanup msix automatically makes pci.c depend on > msix.c, which is IMO messy. Since devices do msix_init it's easy and > natural for them to also do msix_uninit. > > Signed-off-by: Michael S. Tsirkin > Cc: Gerd Hoffmann ACK. Patch looks fine, and we've already agreed on doing it this way (devices are responsible for both msix_init and msix_uninit). I just didn't respin my patch series fast enougth ;) cheers, Gerd