From: Jan Kiszka <jan.kiszka@siemens.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Dor Laor <dlaor@redhat.com>, Glauber Costa <glommer@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [PATCH] Register rtc options for -set (was: [Qemu-devel] [PATCH v3 4/5] Refactor RTC command line switches)
Date: Tue, 06 Oct 2009 12:59:13 +0200 [thread overview]
Message-ID: <4ACB2301.4050001@siemens.com> (raw)
In-Reply-To: <1254825174.2720.17.camel@blaa>
Mark McLoughlin wrote:
> On Tue, 2009-09-15 at 13:36 +0200, Jan Kiszka wrote:
>> Deprecate -localtime, -setdate and -rtc-td-hack in favor of a new
>> unified command line switch:
>>
>> -rtc [base=utc|localtime|date][,driftfix=none|slew]
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> qemu-config.c | 17 ++++++++
>> qemu-config.h | 1
>> qemu-options.hx | 47 ++++++++++++-----------
>> vl.c | 111 ++++++++++++++++++++++++++++++++++++++-----------------
>> 4 files changed, 119 insertions(+), 57 deletions(-)
>>
>> diff --git a/qemu-config.c b/qemu-config.c
>> index 39bf6a9..45a3e09 100644
>> --- a/qemu-config.c
>> +++ b/qemu-config.c
>> @@ -151,6 +151,23 @@ QemuOptsList qemu_device_opts = {
>> },
>> };
>>
>> +QemuOptsList qemu_rtc_opts = {
>> + .name = "rtc",
>> + .head = QTAILQ_HEAD_INITIALIZER(qemu_rtc_opts.head),
>> + .desc = {
>> + {
>> + .name = "base",
>> + .type = QEMU_OPT_STRING,
>> +#ifdef TARGET_I386
>> + },{
>> + .name = "driftfix",
>> + .type = QEMU_OPT_STRING,
>> +#endif
>> + },
>> + { /* end if list */ }
>> + },
>> +};
>> +
>> static QemuOptsList *lists[] = {
>> &qemu_drive_opts,
>> &qemu_chardev_opts,
>
> Need to add qemu_rtc_opts to this list for -set
>
Ah, ok, thanks.
Jan
---------->
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
qemu-config.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index ca93dc7..2e396ae 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -176,6 +176,7 @@ static QemuOptsList *lists[] = {
&qemu_drive_opts,
&qemu_chardev_opts,
&qemu_device_opts,
+ &qemu_rtc_opts,
NULL,
};
next prev parent reply other threads:[~2009-10-06 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 11:36 [Qemu-devel] [PATCH v3 0/5] Improve PC RTC emulation Jan Kiszka
2009-09-15 11:36 ` [Qemu-devel] [PATCH v3 2/5] win32: Drop dead dyntick timer code Jan Kiszka
2009-09-15 11:36 ` [Qemu-devel] [PATCH v3 3/5] Introduce QEMU_CLOCK_HOST Jan Kiszka
2009-09-15 11:36 ` [Qemu-devel] [PATCH v3 4/5] Refactor RTC command line switches Jan Kiszka
2009-10-06 10:32 ` Mark McLoughlin
2009-10-06 10:59 ` Jan Kiszka [this message]
2009-09-15 11:36 ` [Qemu-devel] [PATCH v3 1/5] Rename QEMU_TIMER_* to QEMU_CLOCK_* Jan Kiszka
2009-09-15 11:36 ` [Qemu-devel] [PATCH v3 5/5] Enable host-clock-based RTC Jan Kiszka
2009-09-15 17:50 ` [Qemu-devel] Re: [PATCH v3 0/5] Improve PC RTC emulation Jamie Lokier
2009-09-15 18:51 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACB2301.4050001@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=dlaor@redhat.com \
--cc=glommer@redhat.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).