From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvFZq-0004ME-Ez for qemu-devel@nongnu.org; Tue, 06 Oct 2009 15:20:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvFZl-0004GR-Lb for qemu-devel@nongnu.org; Tue, 06 Oct 2009 15:20:01 -0400 Received: from [199.232.76.173] (port=47343 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvFZk-0004F3-0E for qemu-devel@nongnu.org; Tue, 06 Oct 2009 15:19:56 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:9201) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvFZj-0006zp-HU for qemu-devel@nongnu.org; Tue, 06 Oct 2009 15:19:55 -0400 Received: by fg-out-1718.google.com with SMTP id e21so781779fga.10 for ; Tue, 06 Oct 2009 12:19:54 -0700 (PDT) Message-ID: <4ACB9852.6070300@codemonkey.ws> Date: Tue, 06 Oct 2009 14:19:46 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Make NICInfo string fields non-const References: <1254827783.2720.42.camel@blaa> <1254827836-11021-4-git-send-email-markmc@redhat.com> In-Reply-To: <1254827836-11021-4-git-send-email-markmc@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: qemu-devel@nongnu.org Mark McLoughlin wrote: > We now only assign strdup()ed strings to these fields, never static > strings. > > Signed-off-by: Mark McLoughlin > This breaks the build because of a literal assignment in mips_jazz.c. Regards, Anthony Liguori > void *private; >