From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvHp1-0006lS-SH for qemu-devel@nongnu.org; Tue, 06 Oct 2009 17:43:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvHov-0006j2-QX for qemu-devel@nongnu.org; Tue, 06 Oct 2009 17:43:50 -0400 Received: from [199.232.76.173] (port=51750 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvHov-0006ix-M2 for qemu-devel@nongnu.org; Tue, 06 Oct 2009 17:43:45 -0400 Received: from qw-out-1920.google.com ([74.125.92.144]:2390) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvHov-0004N7-Bp for qemu-devel@nongnu.org; Tue, 06 Oct 2009 17:43:45 -0400 Received: by qw-out-1920.google.com with SMTP id 5so1427979qwc.4 for ; Tue, 06 Oct 2009 14:43:45 -0700 (PDT) Message-ID: <4ACBBA0E.7040905@codemonkey.ws> Date: Tue, 06 Oct 2009 16:43:42 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: {} as in linux kernel References: <20091006190115.GA4768@redhat.com> <4ACBB1B5.7010704@mail.berlios.de> In-Reply-To: <4ACBB1B5.7010704@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers , "Michael S. Tsirkin" Stefan Weil wrote: > Michael S. Tsirkin schrieb: > >> Most people seem to hate using {} around sngle-statement blocks. >> And code isn't consistent either way. So let's change our standard >> to something most people like, and eliminate the pain source. >> >> >> > > Inconsistency is not an argument for or against {}. > I don't like single statement blocks without {} > because of my personal experience with all kinds > of code standard variants. > > Please don't change the qemu standard, I like it as it is. > I've never liked this but I would rather not see unnecessary churn so I'd prefer to keep the coding style as-is. Regards, Anthony Liguori