From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvWMH-0000YP-FK
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:15:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvWMC-0000Tz-B6
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:15:08 -0400
Received: from [199.232.76.173] (port=36448 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvWMA-0000TY-M0
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:15:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4701)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MvWMA-0001z6-5y
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:15:02 -0400
Message-ID: <4ACC944C.4020103@redhat.com>
Date: Wed, 07 Oct 2009 15:14:52 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v2 1/5] net: macaddr tweaks.
References: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
	<1254918996-26050-2-git-send-email-kraxel@redhat.com>
	<4ACC922F.6020505@codemonkey.ws>
In-Reply-To: <4ACC922F.6020505@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

>> +typedef uint8_t macaddr_t[6];
>
> Let's make it a stronger type and avoid introducing more _t types. I'd
> suggest:

Oh yes, killing that _t was on the todo list anyway, forgot it.
Will do for the next respin.

> typedef struct MacAddress
> {
> uint8_t addr[6];
> } MacAddress

Why the extra struct?

cheers,
   Gerd