From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvWNM-0000rp-RT for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:16:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvWNG-0000o3-OR for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:16:15 -0400 Received: from [199.232.76.173] (port=36455 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvWNG-0000nc-0T for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:16:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1026) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvWNF-000292-5k for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:16:09 -0400 Message-ID: <4ACC948C.7010602@redhat.com> Date: Wed, 07 Oct 2009 15:15:56 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH v2 3/5] ne2k: work without vlan. References: <1254918996-26050-1-git-send-email-kraxel@redhat.com> <1254918996-26050-4-git-send-email-kraxel@redhat.com> <4ACC926C.6000205@codemonkey.ws> In-Reply-To: <4ACC926C.6000205@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 10/07/09 15:06, Anthony Liguori wrote: >> - qemu_send_packet(s->vc, s->mem + index, s->tcnt); >> + if (s->vc) >> + qemu_send_packet(s->vc, s->mem + index, s->tcnt); >> } > > Perhaps we should just push the s->vc check into qemu_send_packet since > we want this behavior consistently. Makes sense indeed. Will change it. cheers, Gerd