From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvWSZ-0003Ea-DL
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:21:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvWSU-0003AL-Kb
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:21:38 -0400
Received: from [199.232.76.173] (port=40288 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvWST-0003A3-GR
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:21:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56684)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MvWST-000324-3E
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:21:33 -0400
Message-ID: <4ACC95D3.6070305@redhat.com>
Date: Wed, 07 Oct 2009 15:21:23 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option
	rom loading.
References: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
	<1254918996-26050-6-git-send-email-kraxel@redhat.com>
	<4ACC92C8.8060700@codemonkey.ws>
In-Reply-To: <4ACC92C8.8060700@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 10/07/09 15:08, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> + if (s->pxe) {
>> + if (rom_add_option("pxe-ne2k_isa.bin") != 0) {
>> + qemu_error("warning: loading rom pxe-ne2k_isa.bin failed\n");
>> + s->pxe = 0;
>> + }
>> + }
>> +
>
> Maybe we should make the filename a property instead of adding a pxe
> option?

No.  The user should not need to know the file name of the option rom 
just to enable pxe booting for the nic.

When making the filename configurable it should be a separate property 
like "rom-name" or simliar.  I would suggest to NOT implement it unless 
users actually ask for it ;)

cheers,
   Gerd