From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvWUL-0004M9-0F
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:23:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvWUG-0004IS-6e
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:23:28 -0400
Received: from [199.232.76.173] (port=40320 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvWUF-0004IC-La
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:23:23 -0400
Received: from qw-out-1920.google.com ([74.125.92.149]:26656)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MvWUF-0003Jy-ER
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:23:23 -0400
Received: by qw-out-1920.google.com with SMTP id 5so1606625qwc.4
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2009 06:23:22 -0700 (PDT)
Message-ID: <4ACC9646.3020807@codemonkey.ws>
Date: Wed, 07 Oct 2009 08:23:18 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v2 1/5] net: macaddr tweaks.
References: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
	<1254918996-26050-2-git-send-email-kraxel@redhat.com>
	<4ACC922F.6020505@codemonkey.ws> <4ACC944C.4020103@redhat.com>
In-Reply-To: <4ACC944C.4020103@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>>> +typedef uint8_t macaddr_t[6];
>>
>> Let's make it a stronger type and avoid introducing more _t types. I'd
>> suggest:
>
> Oh yes, killing that _t was on the todo list anyway, forgot it.
> Will do for the next respin.
>
>> typedef struct MacAddress
>> {
>> uint8_t addr[6];
>> } MacAddress
>
> Why the extra struct?

To make the type strong so that type checking actually works.

Regards,

Anthony Liguori