From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvWZ1-000756-Ax
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:28:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvWYt-000733-30
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:28:16 -0400
Received: from [199.232.76.173] (port=33967 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvWYs-00072u-61
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:28:10 -0400
Received: from qw-out-1920.google.com ([74.125.92.150]:6855)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MvWYr-000477-SS
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:28:10 -0400
Received: by qw-out-1920.google.com with SMTP id 5so1608383qwc.4
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2009 06:28:09 -0700 (PDT)
Message-ID: <4ACC9765.3030300@codemonkey.ws>
Date: Wed, 07 Oct 2009 08:28:05 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option
	rom loading.
References: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
	<1254918996-26050-6-git-send-email-kraxel@redhat.com>
	<4ACC92C8.8060700@codemonkey.ws> <4ACC95D3.6070305@redhat.com>
In-Reply-To: <4ACC95D3.6070305@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> On 10/07/09 15:08, Anthony Liguori wrote:
>> Gerd Hoffmann wrote:
>>> + if (s->pxe) {
>>> + if (rom_add_option("pxe-ne2k_isa.bin") != 0) {
>>> + qemu_error("warning: loading rom pxe-ne2k_isa.bin failed\n");
>>> + s->pxe = 0;
>>> + }
>>> + }
>>> +
>>
>> Maybe we should make the filename a property instead of adding a pxe
>> option?
>
> No.  The user should not need to know the file name of the option rom 
> just to enable pxe booting for the nic.

Having a pxe flag is somewhat odd.  Real network devices always have 
roms and they always get loaded.  They register themselves as BEV 
devices and the normal boot selection is used to determine whether a 
particular NIC gets network booted or not.

Our roms do expose themselves as BEV roms so there's really no harm in 
loading an option rom while booting from disk.

Any PCI device can have a rom and it probably should be a generic 
property of any PCI device.  There's really nothing specific about 
network adapters.

> When making the filename configurable it should be a separate property 
> like "rom-name" or simliar.  I would suggest to NOT implement it 
> unless users actually ask for it ;)

Quite a few users today replace the standard etherboot roms with gPXE roms.

Regards,

Anthony Liguori