From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvX4M-0005Fg-6M for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:00:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvX4H-0005Bk-9B for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:00:41 -0400 Received: from [199.232.76.173] (port=40329 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvX4G-0005Av-Rn for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:00:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65330) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvX4E-00019n-Vi for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:00:35 -0400 Message-ID: <4ACC9EF9.1010201@redhat.com> Date: Wed, 07 Oct 2009 16:00:25 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading. References: <1254918996-26050-1-git-send-email-kraxel@redhat.com> <1254918996-26050-6-git-send-email-kraxel@redhat.com> <4ACC92C8.8060700@codemonkey.ws> <4ACC95D3.6070305@redhat.com> <4ACC9765.3030300@codemonkey.ws> In-Reply-To: <4ACC9765.3030300@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 10/07/09 15:28, Anthony Liguori wrote: > Having a pxe flag is somewhat odd. Real network devices always have roms > and they always get loaded. They register themselves as BEV devices and > the normal boot selection is used to determine whether a particular NIC > gets network booted or not. > > Our roms do expose themselves as BEV roms so there's really no harm in > loading an option rom while booting from disk. Wrong. Loading a pxe rom makes qemu trying to boot from it, even with -boot c (using the roms shipped in pc-bios/). Maybe SeaBIOS has better BEV support and handles things differently, so we could load them unconditionally once we made the switch. > Any PCI device can have a rom and it probably should be a generic > property of any PCI device. There's really nothing specific about > network adapters. It's pc-specific though, so when we go the route of loading roms unconditionally we need to wrap that into a machine-specific helper function so it happes on TARGET_I386 only. >> When making the filename configurable it should be a separate property >> like "rom-name" or simliar. I would suggest to NOT implement it unless >> users actually ask for it ;) > > Quite a few users today replace the standard etherboot roms with gPXE roms. Usually with the same file names though, so a simple '-boot n' continues to work. cheers, Gerd