From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvX4n-0005Yl-JP
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:01:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvX4j-0005WB-Rb
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:01:09 -0400
Received: from [199.232.76.173] (port=40340 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvX4j-0005W3-Mq
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:01:05 -0400
Received: from mail-qy0-f173.google.com ([209.85.221.173]:45400)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MvX4j-0001G8-7O
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:01:05 -0400
Received: by qyk3 with SMTP id 3so4346933qyk.4
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2009 07:01:04 -0700 (PDT)
Message-ID: <4ACC9F10.60204@codemonkey.ws>
Date: Wed, 07 Oct 2009 09:00:48 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio-console: Add a virtio-console
	bus, support for multiple ports
References: <4AC3A5E6.6070703@redhat.com>	<20091001045439.GA18563@amit-x200.redhat.com>	<4AC46A7A.6030809@redhat.com>	<20091001085620.GB8385@amit-x200.redhat.com>	<20091001104843.GA12334@amit-x200.redhat.com>	<4AC49D79.9070800@redhat.com>	<20091007092519.GB29515@amit-x200.redhat.com>	<4ACC6492.6010808@redhat.com>	<20091007100641.GC29515@amit-x200.redhat.com>	<4ACC7CA5.4030704@redhat.com>	<20091007114257.GA22238@amit-x200.redhat.com>
	<4ACC9240.4040008@redhat.com>
In-Reply-To: <4ACC9240.4040008@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> On 10/07/09 13:42, Amit Shah wrote:
>> On (Wed) Oct 07 2009 [13:33:57], Gerd Hoffmann wrote:
>>> Second, the bus= argument is optional.  If not specified, qdev will 
>>> pick
>>> the first bus of a matching type it finds.  So as long you have a 
>>> single
>>> port/scsi/usb/... bus only you don't need bus= at all.  You can do:
>>
>> The problem with this is that the management solution needs to know then
>> what is the default bus name (which could change if the code gets
>> updated).
>
> No problem.  Just don't use -virtioconsole.  Go with -device 
> virtio-serial-bus,id=... + -device virtport,bus=.. then and explicitly 
> name your devices (and thereby the buses too).
>
> -virtioconsole should *really* be a pure backward compatibility thing. 
> Use case:  You have a script starting qemu using -virtioconsole.  
> After upgrading qemu it should continue to work, i.e. create a device 
> which the guest can use as before the upgrade and which is linked up 
> to a chardev as it was before.
>
> Anything which wants to use the new features can (and should) 
> completely ignore -virtioconsole.  I just wanted to point out that 
> mixing old and new style is *possible*.  It wasn't my intention to 
> imply that I *recommend* doing that.

I agree.

Regards,

Anthony Liguori