From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvXKo-0000z7-Ru
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:17:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvXKk-0000vg-S3
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:17:42 -0400
Received: from [199.232.76.173] (port=47662 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvXKk-0000vV-AR
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:17:38 -0400
Received: from mail-qy0-f173.google.com ([209.85.221.173]:44913)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MvXKj-0004Nz-7k
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:17:37 -0400
Received: by qyk3 with SMTP id 3so4361978qyk.4
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2009 07:17:36 -0700 (PDT)
Message-ID: <4ACCA2FC.6010002@codemonkey.ws>
Date: Wed, 07 Oct 2009 09:17:32 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option
	rom loading.
References: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
	<1254918996-26050-6-git-send-email-kraxel@redhat.com>
	<4ACC92C8.8060700@codemonkey.ws> <4ACC95D3.6070305@redhat.com>
	<4ACC9765.3030300@codemonkey.ws> <4ACC9EF9.1010201@redhat.com>
In-Reply-To: <4ACC9EF9.1010201@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> On 10/07/09 15:28, Anthony Liguori wrote:
>> Having a pxe flag is somewhat odd. Real network devices always have roms
>> and they always get loaded. They register themselves as BEV devices and
>> the normal boot selection is used to determine whether a particular NIC
>> gets network booted or not.
>>
>> Our roms do expose themselves as BEV roms so there's really no harm in
>> loading an option rom while booting from disk.
>
> Wrong.  Loading a pxe rom makes qemu trying to boot from it, even with 
> -boot c (using the roms shipped in pc-bios/).

Only with the e1000 because the rom is misconfig.  Try the ne2k or the 
rtl8139.

>> Any PCI device can have a rom and it probably should be a generic
>> property of any PCI device. There's really nothing specific about
>> network adapters.
>
> It's pc-specific though, so when we go the route of loading roms 
> unconditionally we need to wrap that into a machine-specific helper 
> function so it happes on TARGET_I386 only.

No, it's not pc-specific.  An e1000 card on a PPC still has an x86 
option rom.  Whether it gets loaded and how it gets loaded depends on 
the target, but not the existence of the rom on the device.

Regards,

Anthony Liguori