From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvXRk-0007TT-Bw for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:24:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvXRg-0007Rg-Ry for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:24:52 -0400 Received: from [199.232.76.173] (port=35288 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvXRg-0007RY-Nb for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:24:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50461) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvXRg-0005jG-9r for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:24:48 -0400 Message-ID: <4ACCA4AD.7050606@redhat.com> Date: Wed, 07 Oct 2009 16:24:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20091007123348.GA31537@redhat.com> <4ACC9133.9060903@redhat.com> <20091007134853.GA9769@redhat.com> In-Reply-To: <20091007134853.GA9769@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qemu/pci: optimize pci config handling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Isaku Yamahata , qemu-devel@nongnu.org > I'm actively trying to get out of range-checking address. I don't understand what you mean, sorry. > What you porpose here is certainly more code than we had. > So why is this a good idea? Because it avoids the memcpy/memcmp most of the time (when the memcmp would surely succeed). I supposed that would also matter more as the config space size increases---correct me and dismiss the patch if I am mistaken. Paolo