From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvXUe-0000YD-M1 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:27:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvXUa-0000VV-2d for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:27:52 -0400 Received: from [199.232.76.173] (port=40893 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvXUa-0000VP-0G for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:27:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60142) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvXUY-0006HN-Pv for qemu-devel@nongnu.org; Wed, 07 Oct 2009 10:27:47 -0400 Message-ID: <4ACCA55A.1020602@redhat.com> Date: Wed, 07 Oct 2009 16:27:38 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading. References: <1254918996-26050-1-git-send-email-kraxel@redhat.com> <1254918996-26050-6-git-send-email-kraxel@redhat.com> <4ACC92C8.8060700@codemonkey.ws> <4ACC95D3.6070305@redhat.com> <4ACC9765.3030300@codemonkey.ws> <4ACC9EF9.1010201@redhat.com> <4ACCA2FC.6010002@codemonkey.ws> In-Reply-To: <4ACCA2FC.6010002@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org >> Wrong. Loading a pxe rom makes qemu trying to boot from it, even with >> -boot c (using the roms shipped in pc-bios/). > > Only with the e1000 because the rom is misconfig. Try the ne2k or the > rtl8139. rtl8139 works indeed (and shows up in the F12 menu as it should). >> It's pc-specific though, so when we go the route of loading roms >> unconditionally we need to wrap that into a machine-specific helper >> function so it happes on TARGET_I386 only. > > No, it's not pc-specific. An e1000 card on a PPC still has an x86 option > rom. Whether it gets loaded and how it gets loaded depends on the > target, but not the existence of the rom on the device. Yep, the *loading* is what I was referring to (see $subject) ... cheers, Gerd