From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvYik-0005kd-C4
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 11:46:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvYif-0005XV-HF
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 11:46:29 -0400
Received: from [199.232.76.173] (port=44543 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvYif-0005X8-Cj
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 11:46:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56462)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <john.cooper@redhat.com>) id 1MvYie-0004EM-VS
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 11:46:25 -0400
Message-ID: <4ACCB5DF.9090908@redhat.com>
Date: Wed, 07 Oct 2009 11:38:07 -0400
From: john cooper <john.cooper@redhat.com>
MIME-Version: 1.0
References: <4AB8DD53.7070806@redhat.com> <4AB8DECA.3090908@redhat.com>
	<4AB8E88C.4040103@redhat.com> <4AB980E6.2070203@codemonkey.ws>
	<4AB9AA8E.7060800@third-harmonic.com> <4AC1A4AD.10509@redhat.com>
	<4ACA1527.9050305@third-harmonic.com>
	<20091005195409.GB3399@redhat.com>
	<4ACC2BE6.2080205@redhat.com> <4ACC9C30.2080505@codemonkey.ws>
	<20091007135238.GB9769@redhat.com> <4ACC9DEE.3080605@codemonkey.ws>
In-Reply-To: <4ACC9DEE.3080605@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] fix virtio_blk serial pci config breakage,
	v2
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, john.cooper@redhat.com, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Vadim Rozenfeld <vrozenfe@redhat.com>, jens.axboe@oracle.com, Avi Kivity <avi@redhat.com>

Anthony Liguori wrote:
> Really, I strongly dislike passing this identity page via virtio.  Why
> are we still going this route instead of just passing the S/N?

I believe we've accumulated enough justification to
abandon use of the ata identify interface.

Anthony Liguori wrote:
> Right, we'll need to fix this in the IDE emulation.  I assume we do
> something like that in SCSI also.

Yes, unfortunately that code is stuffing 4 chars
of QEMU_VERSION into the return of an inquiry
command.  It appears this interface as well could
use some attention.

-john

-- 
john.cooper@redhat.com