From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvZNR-0005Rs-MJ for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:28:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvZNM-0005PL-R7 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:28:33 -0400 Received: from [199.232.76.173] (port=50179 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvZNM-0005P1-LJ for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:28:28 -0400 Received: from mail-qy0-f190.google.com ([209.85.221.190]:42392) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvZNL-0002zZ-TC for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:28:28 -0400 Received: by qyk28 with SMTP id 28so418369qyk.16 for ; Wed, 07 Oct 2009 09:28:26 -0700 (PDT) Message-ID: <4ACCC1A5.5020306@codemonkey.ws> Date: Wed, 07 Oct 2009 11:28:21 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20091007132006.GA9668@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" > There's nothing to review in this particular case, the thing was plain > broken, besides same thing was already discussed between me and > Andrzej, see for instance: > http://www.mail-archive.com/qemu-devel@nongnu.org/msg09542.html > > Needless to say the revert is broken also. > Yeah, I understand the race the original commit fixes but I don't understand how the original commit broke WinXP. Do you have further insight Michael? Blindly reverting something that appears right because of a regression is likely just papering over a bigger problem. Regards, Anthony Liguori