From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvbLn-00042d-6R
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 14:34:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvbLi-0003pK-HL
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 14:34:58 -0400
Received: from [199.232.76.173] (port=53450 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvbLi-0003pC-EX
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 14:34:54 -0400
Received: from mail-qy0-f178.google.com ([209.85.221.178]:43948)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MvbLi-0007Hs-7Z
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 14:34:54 -0400
Received: by qyk8 with SMTP id 8so5136757qyk.24
	for <qemu-devel@nongnu.org>; Wed, 07 Oct 2009 11:34:49 -0700 (PDT)
Message-ID: <4ACCDF44.9010704@codemonkey.ws>
Date: Wed, 07 Oct 2009 13:34:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option
	rom loading.
References: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
	<1254918996-26050-6-git-send-email-kraxel@redhat.com>
	<4ACC92C8.8060700@codemonkey.ws> <4ACC95D3.6070305@redhat.com>
	<4ACC9765.3030300@codemonkey.ws> <4ACC9EF9.1010201@redhat.com>
	<4ACCA2FC.6010002@codemonkey.ws> <4ACCA55A.1020602@redhat.com>
In-Reply-To: <4ACCA55A.1020602@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>>> Wrong. Loading a pxe rom makes qemu trying to boot from it, even with
>>> -boot c (using the roms shipped in pc-bios/).
>>
>> Only with the e1000 because the rom is misconfig. Try the ne2k or the
>> rtl8139.
>
> rtl8139 works indeed (and shows up in the F12 menu as it should).
>
>>> It's pc-specific though, so when we go the route of loading roms
>>> unconditionally we need to wrap that into a machine-specific helper
>>> function so it happes on TARGET_I386 only.
>>
>> No, it's not pc-specific. An e1000 card on a PPC still has an x86 option
>> rom. Whether it gets loaded and how it gets loaded depends on the
>> target, but not the existence of the rom on the device.
>
> Yep, the *loading* is what I was referring to (see $subject) ...

Well, I guess I'm confused about where we stand.

Are you suggesting that we drop the pxe property and load the roms 
unconditionally?  The tricky thing here is that we only want to load a 
particular rom once.  There's no need to load the rtl8139 multiple times 
for multiple nics.

Regards,

Anthony Liguori