From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mvfvn-00030I-Sa for qemu-devel@nongnu.org; Wed, 07 Oct 2009 19:28:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mvfvj-0002zK-JG for qemu-devel@nongnu.org; Wed, 07 Oct 2009 19:28:27 -0400 Received: from [199.232.76.173] (port=41132 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mvfvj-0002zH-Dq for qemu-devel@nongnu.org; Wed, 07 Oct 2009 19:28:23 -0400 Received: from qw-out-1920.google.com ([74.125.92.150]:16100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mvfvj-0001IF-4K for qemu-devel@nongnu.org; Wed, 07 Oct 2009 19:28:23 -0400 Received: by qw-out-1920.google.com with SMTP id 5so1778749qwc.4 for ; Wed, 07 Oct 2009 16:28:22 -0700 (PDT) Message-ID: <4ACD2414.9000401@codemonkey.ws> Date: Wed, 07 Oct 2009 18:28:20 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2 9/9] Add -kvm option References: <1254953315-5761-2-git-send-email-glommer@redhat.com> <1254953315-5761-3-git-send-email-glommer@redhat.com> <1254953315-5761-4-git-send-email-glommer@redhat.com> <1254953315-5761-5-git-send-email-glommer@redhat.com> <1254953315-5761-6-git-send-email-glommer@redhat.com> <1254953315-5761-7-git-send-email-glommer@redhat.com> <1254953315-5761-8-git-send-email-glommer@redhat.com> <1254953315-5761-9-git-send-email-glommer@redhat.com> <1254953315-5761-10-git-send-email-glommer@redhat.com> <4ACD1D92.8080607@us.ibm.com> <20091007231405.GQ8092@mothafucka.localdomain> In-Reply-To: <20091007231405.GQ8092@mothafucka.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Andre Przywara , Anthony Liguori , qemu-devel@nongnu.org, Gerd Hoffmann Glauber Costa wrote: > On Wed, Oct 07, 2009 at 06:00:34PM -0500, Anthony Liguori wrote: > >> Glauber Costa wrote: >> >>> This option deprecates --enable-kvm. It is a more flexible option, >>> that makes use of qemu-opts, and allow us to pass on options to enable or >>> disable kernel irqchip, for example. >>> >>> >> With proper qdev support, you could select kvm device models based on >> -device so I think this option isn't all that useful. >> >> What I'd like to see in the interim is a kvm specific machine type >> that's defaulted to if kvm is enabled. I think this would be useful not >> only for enabling things like in-kernel apic, but also for selecting a >> default cpu model. >> > I don't really follow. > > even if we have qdev on the irq controllers, one could still come up with > situations in which we'd like to force the use of one device over another. > Right, my assumption is that the devices will have different qdev names and therefore a user can select which one gets used. Right now, -device is just additive. I'm not sure the best way to express something like, replace this existing device with this new device. Maybe some trickery with id=. Gerd, any thoughts? Regards, Anthony Liguori