From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mvrhc-00073P-FX
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 08:02:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvrhY-0006xb-0s
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 08:02:36 -0400
Received: from [199.232.76.173] (port=46885 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvrhX-0006xK-U5
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 08:02:31 -0400
Received: from david.siemens.de ([192.35.17.14]:17610)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1MvrhX-00069e-7X
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 08:02:31 -0400
Message-ID: <4ACDD4D4.8040207@siemens.com>
Date: Thu, 08 Oct 2009 14:02:28 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1254953315-5761-1-git-send-email-glommer@redhat.com>	<1254953315-5761-2-git-send-email-glommer@redhat.com>	<1254953315-5761-3-git-send-email-glommer@redhat.com>	<1254953315-5761-4-git-send-email-glommer@redhat.com>	<1254953315-5761-5-git-send-email-glommer@redhat.com>	<1254953315-5761-6-git-send-email-glommer@redhat.com>	<1254953315-5761-7-git-send-email-glommer@redhat.com>
	<1254953315-5761-8-git-send-email-glommer@redhat.com>
In-Reply-To: <1254953315-5761-8-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 7/9] initialize i8259 chip
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Glauber Costa wrote:
> diff --git a/kvm-all.c b/kvm-all.c
> index e98024a..418d8bc 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -429,7 +429,6 @@ int kvm_get_irqchip(struct kvm_irqchip *chip)
>  
>      return kvm_vm_ioctl(kvm_state, KVM_GET_IRQCHIP, chip);
>  }
> -#endif
>  
>  int kvm_set_irq(int irq, int level, int *status)
>  {
> @@ -454,6 +453,7 @@ int kvm_set_irq(int irq, int level, int *status)
>  
>      return 1;
>  }
> +#endif

I think these two changes could be avoided by including them in the
previous patch.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux