From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvtRl-0005hd-T3
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 09:54:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvtRh-0005fA-Bi
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 09:54:21 -0400
Received: from [199.232.76.173] (port=58958 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvtRh-0005ex-13
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 09:54:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12404)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MvtRg-0000cx-Ha
	for qemu-devel@nongnu.org; Thu, 08 Oct 2009 09:54:16 -0400
Message-ID: <4ACDEF03.6010406@redhat.com>
Date: Thu, 08 Oct 2009 15:54:11 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1254953315-5761-1-git-send-email-glommer@redhat.com>
	<1254953315-5761-2-git-send-email-glommer@redhat.com>
	<1254953315-5761-3-git-send-email-glommer@redhat.com>
	<1254953315-5761-4-git-send-email-glommer@redhat.com>
	<4ACDEDEC.60706@us.ibm.com>
In-Reply-To: <4ACDEDEC.60706@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>

On 10/08/2009 03:49 PM, Anthony Liguori wrote:
> Glauber Costa wrote:
>> This patch provides kvm with an in-kernel ioapic. We are currently 
>> not enabling it.
>> The code is heavily based on what's in qemu-kvm.git.
>
> It really ought to be it's own file and own device model.  Having the 
> code mixed in with ioapic.c is confusing because it's unclear what 
> code is in use when the in-kernel model is used.

I disagree.  It's the same device with the same guest-visible interface 
and the same host-visible interface (save/restore, 'info ioapic' if we 
write one).  Splitting it into two files will only result in code 
duplication.

Think of it as an ioapic accelerator.

-- 
error compiling committee.c: too many arguments to function