From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Glauber Costa <glommer@redhat.com>,
kvm-devel <kvm@vger.kernel.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic
Date: Thu, 08 Oct 2009 09:26:35 -0500 [thread overview]
Message-ID: <4ACDF69B.5000000@codemonkey.ws> (raw)
In-Reply-To: <4ACDF297.9010303@redhat.com>
Avi Kivity wrote:
> On 10/08/2009 03:55 PM, Anthony Liguori wrote:
>>
>> You should probably just setup VMState such that it directly saves
>> kvm_lapic_state and then have the pre/post functions call the kernel
>> ioctls to sync it. There's not a whole lot of point switching the
>> state between two different structures.
>
> It ensures the two models are compatible. Since they're the same
> device from the point of view of the guest, there's no reason for them
> to have different representations or to be incompatible.
The problem is, the in-kernel apic is not part of the qemu source tree.
If we add a field to the qemu apic, then we would break the in-kernel
apic and vice-versa. It's far easier to just have the in-kernel apic as
a separate model.
Most importantly though, the code should reflect how things behave.
It's extremely difficult to look at the apic code and figure out what
bits are used and what bits aren't used when the in-kernel apic is enabled.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-10-08 14:27 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 22:08 [Qemu-devel] [PATCH v2] Add in-kernel irqchip Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 1/9] add base-addr field to io apic state Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 2/9] Save missing fields in VMState Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 3/9] provide in-kernel ioapic Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 4/9] provide in-kernel apic Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 5/9] provide apic_set_irq_delivered Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 6/9] provide in-kernel i8259 chip Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 7/9] initialize " Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 8/9] Initialize in-kernel irqchip Glauber Costa
2009-10-07 22:08 ` [Qemu-devel] [PATCH v2 9/9] Add -kvm option Glauber Costa
2009-10-07 23:00 ` [Qemu-devel] " Anthony Liguori
2009-10-07 23:14 ` Glauber Costa
2009-10-07 23:28 ` Anthony Liguori
2009-10-12 11:58 ` Gerd Hoffmann
2009-10-12 14:04 ` Anthony Liguori
2009-10-12 15:34 ` Gerd Hoffmann
2009-10-12 16:31 ` Anthony Liguori
2009-10-13 8:05 ` Gerd Hoffmann
2009-10-13 15:33 ` Anthony Liguori
2009-10-13 19:26 ` Markus Armbruster
2009-10-13 20:43 ` Anthony Liguori
2009-10-14 8:08 ` Gerd Hoffmann
2009-10-13 15:36 ` Anthony Liguori
2009-10-13 22:57 ` Jamie Lokier
2009-10-08 14:07 ` Avi Kivity
2009-10-08 14:23 ` Anthony Liguori
2009-10-08 14:30 ` Avi Kivity
2009-10-08 14:33 ` Anthony Liguori
2009-10-08 14:41 ` Avi Kivity
2009-10-08 14:56 ` Anthony Liguori
2009-10-08 15:05 ` Avi Kivity
2009-10-08 15:14 ` Anthony Liguori
2009-10-12 11:15 ` Gerd Hoffmann
2009-10-08 14:34 ` Gleb Natapov
2009-10-08 12:02 ` [Qemu-devel] Re: [PATCH v2 7/9] initialize i8259 chip Jan Kiszka
2009-10-08 13:55 ` [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic Anthony Liguori
2009-10-08 14:09 ` Avi Kivity
2009-10-08 14:22 ` Glauber Costa
2009-10-09 10:06 ` Jamie Lokier
2009-10-09 14:30 ` Glauber Costa
2009-10-09 16:48 ` Jamie Lokier
2009-10-09 18:06 ` Glauber Costa
2009-10-09 19:49 ` Anthony Liguori
2009-10-11 9:10 ` Avi Kivity
2009-10-12 13:41 ` Anthony Liguori
2009-10-08 14:26 ` Anthony Liguori [this message]
2009-10-08 14:31 ` Avi Kivity
2009-10-08 14:39 ` Anthony Liguori
2009-10-08 14:46 ` Glauber Costa
2009-10-08 14:44 ` Glauber Costa
2009-10-08 11:46 ` [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic Jan Kiszka
2009-10-08 13:49 ` Anthony Liguori
2009-10-08 13:54 ` Avi Kivity
2009-10-08 15:53 ` Jan Kiszka
2009-10-08 16:07 ` Jamie Lokier
2009-10-08 16:12 ` Anthony Liguori
2009-10-08 16:17 ` Avi Kivity
2009-10-08 16:22 ` Gleb Natapov
2009-10-08 16:29 ` Avi Kivity
2009-10-08 16:34 ` Gleb Natapov
2009-10-08 16:42 ` Avi Kivity
2009-10-08 17:11 ` Gleb Natapov
2009-10-09 10:02 ` Jamie Lokier
2009-10-09 12:02 ` Gleb Natapov
2009-10-09 14:32 ` Glauber Costa
2009-10-09 16:49 ` Jamie Lokier
[not found] ` <m31vlctk9q.fsf@neno.mitica>
2009-10-09 21:34 ` Glauber Costa
2009-10-12 13:20 ` Anthony Liguori
2009-10-12 14:18 ` Jamie Lokier
2009-10-12 14:49 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACDF69B.5000000@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).