From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mvuk9-0004lR-3C for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:17:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mvuk4-0004gH-FA for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:17:24 -0400 Received: from [199.232.76.173] (port=59178 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mvuk4-0004fy-5c for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:17:20 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:55026) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mvuk3-0002BG-TA for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:17:20 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e34.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n98FCaB4014335 for ; Thu, 8 Oct 2009 09:12:36 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n98FH2vA141644 for ; Thu, 8 Oct 2009 09:17:08 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n98FGtwp002138 for ; Thu, 8 Oct 2009 09:16:56 -0600 Message-ID: <4ACE0266.70700@us.ibm.com> Date: Thu, 08 Oct 2009 10:16:54 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20091008145226.GA12275@redhat.com> In-Reply-To: <20091008145226.GA12275@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Avi Kivity , kvm-devel , "qemu-devel@nongnu.org" Michael S. Tsirkin wrote: > On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote: > >>> Reset BARs and a couple of other registers on bus reset, as per PCI >>> spec. >>> >>> >> This commit breaks Windows XP restart. After a restart Windows switches >> from 800x600 cirrus logic vga to 640x480 standard vga. >> > > So I think this is a bios bug. Patchset fixing this applied. > > So, what's the best way to propagate the fixes upstream? > Avi, Anthony, please advise. > > Avi, after applying this, you need to generate a new bios binary. > > Anthony, qemu keeps bios binaries in source tree. > I can't post a patch changing these, can I? > Only people with git access can change them. > > BTW, can't we keep the sources around the like qemu-kvm does? > It would be best if pc-bios used git, then we would > include a submodule, as it is we can set up a git-cvs > mirror at qemu site, and then include a submodule. > Makes sense? > This is exactly what we do. Look at roms/pc-bios. -- Regards, Anthony Liguori